-
Notifications
You must be signed in to change notification settings - Fork 28
625 feat vpc version management #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| subnet_id='1bc849dc-4426-455a-8207-fb5f726c6ff7', | ||
| endpoint_service_id='b002616f-f386-4da1-8118-04d5e090200f', | ||
| vpc_id='80a6ba4b-44d7-4c57-be40-5013a1e55273', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all values are hardcoded, can you change it?
| attrs = { | ||
| 'name': lb_name, | ||
| 'description': 'ELB for VPCEP functional tests', | ||
| 'vip_subnet_cidr_id': _shared_subnet_id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are, you sure, that is correct parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which one you mean here?
vip_subnet_cidr_id exists in doc
https://docs.otc.t-systems.com/elastic-load-balancing/api-ref/apis_v3/load_balancer/creating_a_load_balancer.html#createloadbalancer
| self.assertIn(updated_name, fetched.service_name) | ||
| self.assertTrue(fetched.is_approval_enabled) | ||
|
|
||
| def test_delete_service(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can skip this test, because delete already in cleanup
anton-sidelnikov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look at the comments
|
Build failed. ✔️ otc-tox-docs SUCCESS in 11m 03s |
|
Build succeeded. ✔️ otc-tox-docs SUCCESS in 12m 10s |
No description provided.