Skip to content

Conversation

@RusselSand
Copy link
Contributor

No description provided.

@RusselSand RusselSand linked an issue Jan 26, 2026 that may be closed by this pull request
Comment on lines 24 to 26
subnet_id='1bc849dc-4426-455a-8207-fb5f726c6ff7',
endpoint_service_id='b002616f-f386-4da1-8118-04d5e090200f',
vpc_id='80a6ba4b-44d7-4c57-be40-5013a1e55273',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all values are hardcoded, can you change it?

attrs = {
'name': lb_name,
'description': 'ELB for VPCEP functional tests',
'vip_subnet_cidr_id': _shared_subnet_id,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are, you sure, that is correct parameter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.assertIn(updated_name, fetched.service_name)
self.assertTrue(fetched.is_approval_enabled)

def test_delete_service(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can skip this test, because delete already in cleanup

Copy link
Member

@anton-sidelnikov anton-sidelnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look at the comments

@otc-zuul
Copy link
Contributor

otc-zuul bot commented Jan 27, 2026

Build failed.
https://zuul.otc-service.com/t/eco/buildset/059420c2c2094083b7f8426c7a6acbb6

✔️ otc-tox-docs SUCCESS in 11m 03s
✔️ build-otc-releasenotes SUCCESS in 4m 26s
✔️ otc-tox-py310 SUCCESS in 4m 27s
✔️ otc-tox-pep8 SUCCESS in 4m 18s
tox-functional-eu-de FAILURE in 14m 58s
✔️ otce-upload-image SUCCESS in 4m 11s

@otc-zuul
Copy link
Contributor

otc-zuul bot commented Jan 27, 2026

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/d1537dd8f5fd4455a74d45f990ca7892

✔️ otc-tox-docs SUCCESS in 12m 10s
✔️ build-otc-releasenotes SUCCESS in 4m 06s
✔️ otc-tox-py310 SUCCESS in 3m 42s
✔️ otc-tox-pep8 SUCCESS in 3m 42s
✔️ tox-functional-eu-de SUCCESS in 15m 42s
✔️ otce-upload-image SUCCESS in 4m 19s

@otc-zuul otc-zuul bot merged commit 31ccae0 into main Jan 27, 2026
4 checks passed
@otc-zuul otc-zuul bot deleted the 625-feat-vpc-version-management branch January 27, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat.] VPC Version Management

3 participants